Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to jk01 keyboard #2057

Merged
merged 8 commits into from
Nov 20, 2023
Merged

Add support to jk01 keyboard #2057

merged 8 commits into from
Nov 20, 2023

Conversation

gskygithub
Copy link
Contributor

Description

Add jukaie/jk01 keyboard

QMK Pull Request

qmk/qmk_firmware#20573

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

v3/jukaie/jk01/jk01.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gskygithub gskygithub requested a review from Xelus22 October 23, 2023 09:33
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still havent fixed it
image

@gskygithub
Copy link
Contributor Author

Still havent fixed it image

@Xelus22 For me, it is looking normal in VIA.
image

@gskygithub gskygithub requested a review from Xelus22 November 1, 2023 01:50
@Xelus22
Copy link
Collaborator

Xelus22 commented Nov 5, 2023

Please follow the VIA docs. Alphas are cccccc, and the mods and accents. It looks different when you go to settings and change the theme.

@gskygithub
Copy link
Contributor Author

@Xelus22 Resolved requested changes, please take a look, thanks.

@Xelus22 Xelus22 merged commit a734208 into the-via:master Nov 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants