Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Idobao ID96 VIA support #952

Merged
merged 3 commits into from
Nov 2, 2021
Merged

Add Idobao ID96 VIA support #952

merged 3 commits into from
Nov 2, 2021

Conversation

vinorodrigues
Copy link
Contributor

Description

Addition of the Idobao ID96 keyboard.

This is in essence the same PCB as the YMDK Melody 96, but the Idobao has an integrated plate that does not allow the installation of the L-Shape Enter key of the ISO layout. This VIA JSON file does not include the ISO option, and allows the identification of the keyboard based on it's QMK MANUFACTURER and PRODUCT ID's.

QMK Pull Request

The keyboard was included into QMK in commit #b5cc2bd / pull request #14371, and is present in the keyboards/idobao/id96 folder.

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@wilba wilba merged commit 29834f0 into the-via:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants