Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SIRIND's Brick65S #44

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add SIRIND's Brick65S #44

wants to merge 2 commits into from

Conversation

eerraa
Copy link

@eerraa eerraa commented Dec 24, 2024

Add SIRIND's Brick65S

Description

This is the Solder PCB for SIRIND's Brick65.
Please allow me to add this to the VIA.

QMK Pull Request

qmk/qmk_firmware#24315

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • I have tested this keyboard definition with firmware on a device.(MANDATORY)
  • VIA keymap uses custom menus
  • The Vendor ID is not 0xFEED

@eerraa
Add Brick65S
610d1fb 
Add Brick65S
@eerraa
Add Brick65S
43dc01d 
Add Brick65S
@Cipulot Cipulot mentioned this pull request Feb 2, 2025
Open
4 tasks
@Cipulot
Copy link

Cipulot commented Feb 2, 2025

See comment in #56

@Cipulot Cipulot added the needs work The PR needs fixes/ things need to be addressed label Feb 2, 2025
@eerraa
Copy link
Author

eerraa commented Feb 2, 2025

@Cipulot
Thank you for your assistance.
The Custom UI code for Brick65S is used independently and is not duplicated.
In this case, would it be possible to merge this as is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs work The PR needs fixes/ things need to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eerraa @Cipulot