Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add intent: quote #18

Merged
merged 7 commits into from
Mar 2, 2020
Merged

add intent: quote #18

merged 7 commits into from
Mar 2, 2020

Conversation

srishti-nema
Copy link
Contributor

Resolves #10 .

@srishti-nema
Copy link
Contributor Author

Should I update test.py and commit??

@RohitRathore1
Copy link
Member

@srishti-nema Yes, you have to update.

swapagarwal
swapagarwal reviewed Mar 2, 2020
View reviewed changes
data/nlu.md Outdated

## intent:quote
- quote
- quote of the day
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm editing this query as it would require special handling compared to the other two. 😅

@swapagarwal swapagarwal merged commit 833206c into the-vision:master Mar 2, 2020
@swapagarwal
Copy link
Member

Thanks @srishti-nema! 👍
Here's a good issue for you to work on next: the-vision/jarvis-telegram#10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapagarwal swapagarwal swapagarwal left review comments

@RohitRathore1 RohitRathore1 RohitRathore1 approved these changes

Assignees
No one assigned
Labels
beginner gssoc20
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new intent: quote
3 participants
@srishti-nema @RohitRathore1 @swapagarwal