Update WASM plugins logic #4686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WakelessSloth56
suggested changes
Mar 18, 2024
| if (fragments.length === 2) { | ||
| await run(fragments[0].title, toast, fragments[0].url, fragments[1].url) // [dash] | ||
| } else { | ||
| await run(fragments[0].title, toast, fragments[0].url) // [flv | m4a] |
There was a problem hiding this comment.
只有单个流的话不用这个插件，没必要过一遍 FFmpeg，报个错就行，让用户直接下载。
| if ( | ||
| fragments.length > 2 || | ||
| (fragments.length === 2 && | ||
| !(fragments[0].extension === '.mp4' && fragments[1].extension === '.m4a')) |
There was a problem hiding this comment.
extension 是可以自定义的（#4449），如果用户自定义了扩展名这里的条件就会出问题。
Direct link download flv/m4a in WASM
|
在我这里ffmpeg处理flac音频时会出现文件异常的情况，这个参数需要改吗 await ffmpeg.exec(['-i', 'video', '-i', 'audio', '-c:v', 'copy', '-c:a', 'copy', 'output.mp4']) |
因为输出是 MP4 容器，它是不支持 FLAC 流的，如果是 FLAC 音频的话用 Matroska 容器（ |
WakelessSloth56
suggested changes
Mar 19, 2024
| @@ -47,3 +45,15 @@ export async function run(name: string, videoUrl: string, audioUrl: string, toas | |||
|
|
|||
| await DownloadPackage.single(name, outputBlob) | |||
| } | |||
|
|
|||
| export async function downloadFromLink(name: string, toast: Toast, url: string) { | |||
There was a problem hiding this comment.
这个插件不需要下载单个文件，这里给出用户提示之后就不要做什么了，下载单个文件已经有 Toast
StreamSaver、aria2、IDM 等很多方式了。
the1812
requested changes
Mar 20, 2024
Add use WASM to download video containing flac audio
the1812
requested changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: 解决旧版WASM下载两个音频或flv存在重复下载的问题,并限制仅支持单个视频下载