-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESM compatibility breaks WebPack build #301
Comments
I'm facing the same issue |
Looks like same problem here. I have
Looks like that it is |
I am facing the same issue, downgrading the module version as @kerbe pointed out seems to fix the issue. |
i'm also facing the same issue, though im using UPDATE: Works with overriding react-focus-lock version in package.json
|
Version 2.12.0 has been deprecated, please use 2.11.3 |
I am not using react-focus-lock directly in my project but its getting installed as a dependency for chakra-ui version 2.8.2 , how can i fix the above issue the issue in this case ? "node_modules/@chakra-ui/focus-lock": { |
@Harsh7wardhan in your "overrides": {
"@chakra-ui/focus-lock": {
"react-focus-lock": "2.11.3"
}
} |
Due to semantic versioning, I think you might have to publish a new version that hot-fixes or reverts the breaking changes introduced in In my "react-focus-lock": "2.11.3" instead of: "react-focus-lock": "^2.11.3" |
Getting same error. The package is broken and unusable. Author doesn't know how to properly publish npm packages. Workaround: Do not update the package version, or your app will break. |
…age breaking ESM breaking WebPack build theKashey/react-focus-lock#301
I added overrides but still doesn't work. But this is working.
|
Working on a resolution:
|
@theKashey Hey mate, just wondering how long on that re-publish, I've got a build that urgently needs QA and I'd rather not use force-resolutions. Can do if needed tho, what timeframe were you thinking? |
I'd suggest doing that.
|
Wondering if just removing Anyway 2.12.1 has been published. |
Please fix this Bug |
@likegs9 The bug seems to be fixed. After installing the new verison, there's no error. |
This issue has been marked as "stale" because there has been no activity for 2 months. If you have any new information or would like to continue the discussion, please feel free to do so. If this issue got buried among other tasks, maybe this message will reignite the conversation. Otherwise, this issue will be closed in 7 days. Thank you for your contributions so far. |
There is no errors because focus-lock is not ESM compatible. Conversion is blocked by underlaying libraries to be migrated first, and that would take time |
https://github.com/theKashey/react-focus-lock/releases/tag/v2.12.0
Unfortunately the ESM compatibility update broke our WebPack build ... I am investigating, but we have a pretty standard setup.
The text was updated successfully, but these errors were encountered: