fix: terser might compress different files differently, fixes #166 #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theKashey
commented
Dec 30, 2019
| }); | ||
|
|
||
| it('work similar for similar functions', () => { | ||
| expect(getFunctionSignature(() => a('imported_XXYY_component'))).toBe( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: If file contains only one
importedsignature thenimportedWrappercould be inlined into that single use case. As a result the code in the file, and the code inasync-importswould be different - #166The fix: more
importedWrappertoreact-imported-component/wrapperProblem:
terseroptimization might mangleimportedWrapper(no matter how it's defined) differently. As a result the code in the file, and the code inasync-importswould be different.The fix:
signaturewould replace anyXXX("imported_to the same result, making usage cases "the same".