Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow partial body scroll #3

Closed
theKashey opened this issue Mar 12, 2019 · 2 comments
Closed

Allow partial body scroll #3

theKashey opened this issue Mar 12, 2019 · 2 comments
Labels

Comments

@theKashey
Copy link
Owner

Remove-scroll right now completely disables scroll outside of the "lock". In the same time, scroll could occur as a result of a "focus-jump" or be driven programmatically in a different way.

Remove scroll shall allow parent container scroll if lock container is not fitting into parent container. Ie - if locks is bigger that window - scroll should be partially allowed, or it would lead to real production issues, not letting customers interact with the content they have to.

@theKashey
Copy link
Owner Author

theKashey commented Oct 29, 2019

on the lock activation a whole target should be in a viewport, and if not, them:

  • reset user zoom, literally zoom out (change user zoom meta tag, try el.scrollToView)
  • make own lock div scrollable (don't forget to test your modals for content overflow)
  • don't activate the lock (and don't trap the user)

if in runtime scroll-lock detects scrolling out of the target - the mechanics listed above have to be reapplied.
The actual behaviour should be configurable by the user, however, some safety net should be active all the time to prevent really bad situations.

PS: keep in mind, zooming in should be allowed with if touchZoom is enabled

@stale
Copy link

stale bot commented Apr 30, 2023

This issue has been marked as "stale" because there has been no activity for 2 months. If you have any new information or would like to continue the discussion, please feel free to do so. If this issue got buried among other tasks, maybe this message will reignite the conversation. Otherwise, this issue will be closed in 7 days. Thank you for your contributions so far.

@stale stale bot added the state label Apr 30, 2023
@stale stale bot closed this as completed May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant