Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll not locked when moving mouse out of window after scroll (Chrome, macOS) #4

Closed
karlhorky opened this issue May 3, 2019 · 3 comments

Comments

@karlhorky
Copy link

First of all, thanks for this project! It seems to work well in most cases.

One case where it doesn't work is the following (admittedly, an edge case):

  1. Scroll a lot with a mouse/setup that allows acceleration scrolling (ex. I have a Magic Mouse)
  2. Move mouse outside of window quickly afterwards
  3. Watch the locked background scroll with the left over acceleration

Kapture 2019-05-03 at 13 34 44

@theKashey
Copy link
Owner

Try again:
What I did:

  • on "scrollbar-free" Systems, like OSx or mobiles, I was not hiding scroll bars as long as they should not be visible in any case. But they were.
  • now scrollbars would be hidden in any case.

I am looking forward to the mix of old and new behaviour for #3, including controlling scrollbars existence for all parents. That was a problem - you were able to bypass scroll-lock using momentum scrolling.

@theKashey theKashey reopened this May 4, 2019
@karlhorky
Copy link
Author

Cool, thanks for the quick response! Will test and report back.

@karlhorky
Copy link
Author

@theKashey Seems like it is fixed with your commit c9c3209 🎉 Nice work.

Closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants