Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include menu-contextual if non-empty #130

Closed
blueyed opened this issue Sep 10, 2018 · 2 comments
Closed

Only include menu-contextual if non-empty #130

blueyed opened this issue Sep 10, 2018 · 2 comments
Assignees

Comments

@blueyed
Copy link

blueyed commented Sep 10, 2018

I was confused about the white / blank space on the right for when there is no TOC / related pages.

Code: https://github.com/budparr/gohugo-theme-ananke/blob/7a32e28d4b239a279ba0415bd26f93f5ced5128c/layouts/_default/single.html#L34-L36

Is it possible to skip the <aside> block complete if it is empty / only contains whitespace?

@blueyed
Copy link
Author

blueyed commented Sep 10, 2018

There's also a CSS issue in this regard: below a width of 960px the aside appears to be below, but between 960-1020px the left and right padding is missing:

2018-09-10-175716_1005x618_escrotum

@budparr budparr self-assigned this Sep 10, 2018
budparr pushed a commit that referenced this issue Jan 8, 2019
budparr pushed a commit that referenced this issue Jan 8, 2019
@budparr
Copy link
Member

budparr commented Jan 8, 2019

Hi @blueyed For the first issue, I believe that was my intent. That is, I would not want the line length to be really wide no matter what is on the page. I fixed the second issue and it's in the latest release. Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants