Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix '+' character being written as + #317

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Fix '+' character being written as + #317

merged 1 commit into from
Jul 20, 2020

Conversation

Bas-Man
Copy link
Contributor

@Bas-Man Bas-Man commented Jul 18, 2020

The existing template code results in the + chartering being written in a form that is not valid for the datetime element when used in and tag.

This patch fixes this issue.
references:
https://discourse.gohugo.io/t/date-lastmod-return-43-in-place-of/27033
gohugoio/hugo#7488

The existing template code results in the + chartering being written in a form that is not valid for the datetime element when used in and <time> tag.

This patch fixes this issue.
references:
https://discourse.gohugo.io/t/date-lastmod-return-43-in-place-of/27033
gohugoio/hugo#7488
@Bas-Man
Copy link
Contributor Author

Bas-Man commented Jul 18, 2020

An alternative option which I have just been informed of. Would be to replace the Z with a '-'

See:https://discourse.gohugo.io/t/date-lastmod-return-43-in-place-of/27033/9?u=adamspann

@budparr budparr requested a review from regisphilibert July 20, 2020 13:28
@regisphilibert
Copy link
Member

Thank you for this @Bas-Man

@regisphilibert regisphilibert merged commit 5e25026 into theNewDynamic:master Jul 20, 2020
Remicck pushed a commit to Remicck/gohugo-theme-ananke that referenced this pull request Mar 7, 2022
The existing template code results in the + chartering being written in a form that is not valid for the datetime element when used in and <time> tag.

This patch fixes this issue.
references:
https://discourse.gohugo.io/t/date-lastmod-return-43-in-place-of/27033
gohugoio/hugo#7488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants