Add control over header image #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add the param to the example with an explanation - It can also be used to add more classes for futher customization if needed
- cover remains the default, but with breakpoints one gains flexibility an can add rules for different devices
❌ Deploy Preview for gohugo-ananke-theme-demo failed. Why did it fail? →
|
|
Not sure why the build fails, it complains about something unrelated to my changes imo. |
|
If you force-push the current state, the Netlify jobs should run without issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request:
Currently, the header image for a post is
bg-top, but it would be nice the control this behavior to lets saytop|center|bottom, as often the interesting part of an image is in the center. Using thefeatured_image_classparam, one can now customize the class to control the alignment of the featured header image. It is also possible to add additional classes for further customization if needed.Explain the details for making this change. What existing problem does the pull request solve?
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Default case:
Same as default case but set explicitly
featured_image_class = cover bg-top:featured_image_class = cover bg-center:featured_image_class = cover bg-bottom:featured_image_class = contain bg-top:Code formatting
Closing issues
Closes #729