Locate the Python interpreter via the py.exe launcher #53

pfmoore · 2017-09-19T08:55:01Z

On Windows, if the default strategy for finding a versioned interpreter fails, ask the py.exe launcher to locate it for us.

pfmoore · 2017-09-19T08:57:40Z

Some outstanding questions:

Does this need tests? It probably should, but the existing tests say "Not testing multiple interpreters on Windows" and I can see why - it's going to be quite hard to test this without mocking a lot of stuff (and possibly reqriting some of the code to make it more testable)
Should this check replace the existing hard-coded list of interpreters? In theory, it's more reliable and the py.exe launcher should always be present.
If we do keep both approaches, should the default list or the py.exe check be first?

theacodes · 2017-09-19T16:46:46Z

Thank you so much for doing this, @pfmoore!

Does this need tests? It probably should, but the existing tests say "Not testing multiple interpreters on Windows" and I can see why - it's going to be quite hard to test this without mocking a lot of stuff (and possibly reqriting some of the code to make it more testable)

I can handle this - it's likely we'll need to mock some stuff for coverage purposes but have a real test for when on an actual windows platform.

Should this check replace the existing hard-coded list of interpreters? In theory, it's more reliable and the py.exe launcher should always be present.

I think so, yes.

If we do keep both approaches, should the default list or the py.exe check be first?

Let's just drop the old method.

theacodes · 2017-09-19T16:49:56Z

nox/virtualenv.py

+    """
+    ver = "-%s.%s" % (v_maj, v_min)
+    script = "import sys; print(sys.executable)"
+    py_exe = distutils.spawn.find_executable('py')


TIL about distutils.spawn.find_executable! Should we use that over py.path.local.sysfind which we use in command?

Honestly, I doubt it matters (I lifted that code from tox unchanged). I'd be inclined to go for consistency and follow current practice by using py.path.local.sysfind in both places. I'll change this.

(BTW, there's also shutil.which in Python 3.3+. Who said "one obvious way"? 😄)

(BTW, there's also shutil.which in Python 3.3+. Who said "one obvious way"? 😄)

I'd love to make nox 3+ only. Sigh.

I'll also make the change to drop the old approach, as noted in your other comment. I can do the tests too, if you want, but if you have a preferred style/approach for the tests and would rather cover that yourself, that's fine too.

We use pytest so as long as it's not terribly different from what's there go for it. :)

pfmoore · 2017-09-20T10:13:57Z

Looking into the coverage failures...

pfmoore · 2017-09-20T11:02:16Z

There's a remaining coverage failure - line 153 in nox/virtualenv.py:

        if self.interpreter:
            cmd.extend(['-p', self._resolved_interpreter])

I'm not sure why the changes I've made would have caused this line to no longer be executed. @jonparrott do you have any suggestions?

theacodes · 2017-09-20T15:43:52Z

I'm not sure why the changes I've made would have caused this line to no longer be executed. @jonparrott do you have any suggestions?

It's my fault, you can disregard that coverage issue.

pfmoore · 2017-09-20T15:44:50Z

I like that sort of answer ;-) In which case I think this is good to go. Could you check it over for me?

theacodes · 2017-09-20T15:50:45Z

LGTM- I updated the docstring to mention pep 397. I'm gonna wait for CI to merge (I know it'll fail due to coverage, just want to make sure that's the only failure).

theacodes · 2017-09-20T15:50:59Z

Thank you so much for doing this @pfmoore! 🍰

theacodes · 2017-09-20T16:02:15Z

All good. Merging. :)

pfmoore · 2017-09-20T17:19:09Z

Glad to help 😄

dhermes · 2017-09-20T19:33:10Z

🎉 Yay Windows!

dhermes · 2017-09-20T20:06:02Z

nox/virtualenv.py

+    """
+    script = "import sys; print(sys.executable)"
+    py_exe = py.path.local.sysfind('py')
+    if py_exe:


@jonparrott Should this be a None-check?

Possibly. If you want you can send a follow-up PR.

Follow-up to wntrblm#53. Also - Using single quotes instead of double quotes - Adding Args/Returns section to docstring

* Adding None-check to `locate_via_py`. Follow-up to #53. Also - Using single quotes instead of double quotes - Adding Args/Returns section to docstring * Updating unit test mocks: faithfully mock `sysfind`.

dhermes · 2017-10-09T02:40:01Z

BTW I am living life happily in Windows land and I can confirm this PR works great (and nox was broken-ish before I pip install git+https://github.com/jonparrott/nox/)

theacodes · 2017-10-09T03:41:18Z

Yay!

…

On Sun, Oct 8, 2017, 7:40 PM Danny Hermes ***@***.***> wrote: BTW I am living life happily in Windows land and I can confirm this PR works great (and nox was broken-ish before I pip install git+ https://github.com/jonparrott/nox/) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#53 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUczPAHH3tbtdrcrl1rYgp1OyzcboMks5sqYeBgaJpZM4PcEEV> .

Locate the Python interpreter via the py.exe launcher

242785d

pfmoore mentioned this pull request Sep 19, 2017

Locate Python interpreters on Windows via the py.exe launcher #46

Closed

theacodes reviewed Sep 19, 2017

View reviewed changes

theacodes mentioned this pull request Sep 19, 2017

Restore result and report output #57

Merged

Use launcher exclusively, add tests

84016f4

pfmoore added 2 commits September 20, 2017 11:37

Fix test coverage

6d26c83

Fix flake8 issues

936411b

Update docstring to mention the pep this is based on.

8258539

theacodes approved these changes Sep 20, 2017

View reviewed changes

Fix tiny lint thing that I borked.

cb5147c

theacodes merged commit 95863f7 into wntrblm:master Sep 20, 2017

dhermes reviewed Sep 20, 2017

View reviewed changes

dhermes added a commit to dhermes/nox that referenced this pull request Sep 20, 2017

Adding None-check to locate_via_py.

fb50f98

Follow-up to wntrblm#53. Also - Using single quotes instead of double quotes - Adding Args/Returns section to docstring

dhermes mentioned this pull request Sep 20, 2017

Adding None-check to locate_via_py. #59

Merged

dhermes mentioned this pull request Oct 12, 2017

Cutting release 0.18.2. #63

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Locate the Python interpreter via the py.exe launcher #53

Locate the Python interpreter via the py.exe launcher #53

pfmoore commented Sep 19, 2017

pfmoore commented Sep 19, 2017

theacodes commented Sep 19, 2017

theacodes Sep 19, 2017

pfmoore Sep 19, 2017

theacodes Sep 19, 2017

pfmoore Sep 19, 2017

theacodes Sep 19, 2017

pfmoore commented Sep 20, 2017

pfmoore commented Sep 20, 2017

theacodes commented Sep 20, 2017

pfmoore commented Sep 20, 2017

theacodes commented Sep 20, 2017

theacodes commented Sep 20, 2017

theacodes commented Sep 20, 2017

pfmoore commented Sep 20, 2017

dhermes commented Sep 20, 2017

dhermes Sep 20, 2017

theacodes Sep 20, 2017

dhermes Sep 20, 2017

dhermes commented Oct 9, 2017

theacodes commented Oct 9, 2017 via email

Locate the Python interpreter via the py.exe launcher #53

Locate the Python interpreter via the py.exe launcher #53

Conversation

pfmoore commented Sep 19, 2017

pfmoore commented Sep 19, 2017

theacodes commented Sep 19, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pfmoore commented Sep 20, 2017

pfmoore commented Sep 20, 2017

theacodes commented Sep 20, 2017

pfmoore commented Sep 20, 2017

theacodes commented Sep 20, 2017

theacodes commented Sep 20, 2017

theacodes commented Sep 20, 2017

pfmoore commented Sep 20, 2017

dhermes commented Sep 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dhermes commented Oct 9, 2017

theacodes commented Oct 9, 2017 via email