Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding None-check to locate_via_py. #59

Merged
merged 2 commits into from
Sep 20, 2017

Conversation

dhermes
Copy link
Collaborator

@dhermes dhermes commented Sep 20, 2017

Follow-up to #53. Also

  • Using single quotes instead of double quotes
  • Adding Args/Returns section to docstring

Follow-up to wntrblm#53. Also

- Using single quotes instead of double quotes
- Adding Args/Returns section to docstring
@theacodes
Copy link
Collaborator

Seems it needs to not be a none-check.

@dhermes
Copy link
Collaborator Author

dhermes commented Sep 20, 2017

@jonparrott It was just the mocks.

In [1]: import py

In [2]: py.path.local.sysfind?
Signature: py.path.local.sysfind(name, checker=None, paths=None)
Docstring:
return a path object found by looking at the systems
underlying PATH specification. If the checker is not None
it will be invoked to filter matching paths.  If a binary
cannot be found, None is returned
Note: This is probably not working on plain win32 systems
but may work on cygwin.
File:      ~/.pyenv/versions/3.6.2/lib/python3.6/site-packages/py/_path/local.py
Type:      method

In [3]: py.path.local.sysfind('python')
Out[3]: local('/home/dhermes/.pyenv/versions/3.6.2/bin/python')

@theacodes theacodes merged commit 503f633 into wntrblm:master Sep 20, 2017
@dhermes dhermes deleted the pr-53-followup branch September 20, 2017 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants