Address lodash security vulnerabilities #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses numerous security vulnerabilities present in the previous requirement of "^2.4.1": * CVE-2018-3721 * CVE-2018-16487 * CVE-2019-10744 * CVE-2019-1010266 * CVE-2020-8203 The change to a ">=" dependency version is intended to allow users of this package to update lodash to address security vulnerabilities more easily in future, even if they *may* run into incompatibilities due to breaking changes, as this package doesn't appear to get updated regularly.
This is required due to a breaking change in the upgrade from lodash 3.x to 4.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can see a number of forks that have attempted to simply update the version dependence, and the same strategy is also applied in the existing PR #82
Simply updating the dependency version appears to lead to errors (at least in my usage) due to a breaking change between lodash 3.x and 4.x, so this PR adds a further update to change usages of
_.containsto_.includesto restore working behaviour with lodash >=4.17.19 (older versions have at least one security vulnerability).I've also taken the opportunity to change the version requirement to a ">=", since this package doesn't get many updates and this will allow users of this package to update lodash to address future security vulnerabilities more easily (even if they may run into incompatibilities due to breaking changes). It would appear that lodash 3.x had no breaking changes that affected this package, so the version requirement has been needlessly strict.