Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor doesn't support touch controls #169

Closed
James-lx opened this issue Jun 29, 2021 · 18 comments
Closed

Editor doesn't support touch controls #169

James-lx opened this issue Jun 29, 2021 · 18 comments
Assignees
Labels
enhancement New feature or request

Comments

@James-lx
Copy link

It's hard to code using iPad virtual keyboard,and it doesn't support selecting using either hand or keyboard but sometimes it can do, I don't know why.

@bummoblizard bummoblizard added the enhancement New feature or request label Jun 30, 2021
@bummoblizard
Copy link
Member

Thank you for the message. This is a known issue from the very beginning. We use monaco-editor, which is the core editor from VS Code. While this gives us great performance, syntax highlighting and other features that VS Code users are familiar with, the editing experience without a hardware keyboard is poor.

I am attempting to patch monaco-editor to support touch controls, but it won't be easy. I am also considering to let users opting for an less powerful, but touch-friendly editor like CodeMirror 6.

@bummoblizard bummoblizard changed the title editing bugs Editor doesn't support touch controls Jun 30, 2021
@James-lx
Copy link
Author

Thank you for your prompt reply
Did you mean I can have better experience using hardware keyboard? But I can't use mouse(without keyboard)to select or others either.

@bummoblizard
Copy link
Member

bummoblizard commented Jun 30, 2021

Yes. You can select text with mouse or trackpad in the latest build: https://testflight.apple.com/join/EgZ8sE2P

It will be released to the App Store in a few days.

@vwkd
Copy link

vwkd commented May 20, 2022

Currently Code is unusable with virtual keyboard due to selection not working.

CodeMirror 6 seems to support this fine. An entire replacement of Monaco or at least an option would be appreciated.

@bummoblizard
Copy link
Member

Currently Code is unusable with virtual keyboard due to selection not working.

CodeMirror 6 seems to support this fine. An entire replacement of Monaco or at least an option would be appreciated.

Yes and I've thought about it. The issue is that CodeMirror doesn't provide many features that are tightly integrated to Code App and maintaining two sets of editor in one app seems troublesome. If you would like to see native controls and a more lightweight editor Runestone Editor does it really well (https://github.com/simonbs/Runestone).

I'm still open to this idea though.

@bummoblizard
Copy link
Member

@benwu030 It's time to revisit this. Besides CodeMirror, Runestone is also a nice candidate for this: https://github.com/simonbs/Runestone. My plan is to support both Monaco Editor and the new editor. Now that we've completed the refactoring of the codebase this should not be too troublesome to implement.

We might need to give up certain feature like diff editors and searching though.

@bummoblizard bummoblizard pinned this issue Nov 27, 2022
@luni-moon
Copy link

I use diff and searching pretty frequently, and would not like this to be removed :(

@bummoblizard
Copy link
Member

I use diff and searching pretty frequently, and would not like this to be removed :(

We will keep both editors :)

@redscorpse
Copy link

I find this issue with text selection annoying too, and I would like to suggest adding something like in Online GDB. It uses the Ace editor (which I don't know if has the same issue as Monaco) but adds to the left column of line numbers the ability of folding and selecting multiple lines.

Select-text-with-column

@jbschooley
Copy link

If you're able to patch monaco-editor to support touch, would you consider upsteaming it? This app is great, but I sometimes use VS Code in safari and on my windows tablet, and touch doesn’t work there either. Fixing that would be incredible.

@SRUKen
Copy link

SRUKen commented Dec 10, 2023

Hi @bummoblizard , new user to Code app, very good by the way, any updates on the second editor for better touchscreen support that you mentioned last year?

@bummoblizard
Copy link
Member

In the latest TestFlight build, you might enable Runestone Editor under the experimental settings section for touch control support.

@D1reW0lf
Copy link

To bad the TestFlight beta is full. 😕

@bummoblizard
Copy link
Member

@D1reW0lf I just opened up more slots :)

@D1reW0lf
Copy link

@D1reW0lf I just opened up more slots :)

Thank you so much!! 🖤
Will it, eventually, “color code” with Runestone?

@bummoblizard
Copy link
Member

Currently there is syntax highlighting for C, C++, JS and Python.

@D1reW0lf
Copy link

Currently there is syntax highlighting for C, C++, JS and Python.

That explains why I didn’t see it (I was testing with html, php, .env files, json).
Thank you for letting me know.

@bummoblizard
Copy link
Member

bummoblizard commented Jun 12, 2024

1.8.0 brings support for Runestone editor which allows native text selection. It can be toggled in the settings menu or in the quick menu.

image
Screen.Recording.2024-06-12.at.21.05.10.mov

This was referenced Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

9 participants