Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Close Workspace Action #814

Merged
merged 1 commit into from
Apr 9, 2023
Merged

Add Close Workspace Action #814

merged 1 commit into from
Apr 9, 2023

Conversation

graphemecluster
Copy link
Contributor

  • … for completeness
  • Use the word “workspace” instead of “workplace” for consistency

@bummoblizard
Copy link
Member

Thanks for the work. Looks good to me but we should handle the case when the existing workspace is located at a remote server. The connection should be terminated gracefully.

@bummoblizard bummoblizard merged commit 16f6a00 into thebaselab:main Apr 9, 2023
@bummoblizard
Copy link
Member

Merged with additional commit: 95ceb65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graphemecluster @bummoblizard