Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compileDebugJavaWithJavac #31

Merged
merged 3 commits into from
May 27, 2021
Merged

fix: compileDebugJavaWithJavac #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ceb97f5
fix: react-native-fbsdk-next:compileDebugJavaWithJavac
UriMiranda May 6, 2021
b393ccd
fix: Make constructor equal to FBAppLinkModule
UriMiranda May 13, 2021
1b96d06
fix: Importing ReactApplicationContext
UriMiranda May 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions android/src/main/java/com/facebook/reactnative/androidsdk/FBProfileModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import com.facebook.react.bridge.NativeModule;
import com.facebook.react.bridge.ReactContextBaseJavaModule;
import com.facebook.react.bridge.ReactMethod;
import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.module.annotations.ReactModule;

import androidx.annotation.NonNull;
Expand All @@ -16,6 +17,10 @@
public class FBProfileModule extends ReactContextBaseJavaModule {
public static final String NAME = "FBProfile";

public FBProfileModule(ReactApplicationContext reactContext) {
super(reactContext);
}

@NonNull
@Override
public String getName() {
Expand Down
2 changes: 1 addition & 1 deletion android/src/main/java/com/facebook/reactnative/androidsdk/FBSDKPackage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public List<NativeModule> createNativeModules(
new FBGraphRequestModule(reactContext),
new FBLoginManagerModule(reactContext, mActivityEventListener),
new FBMessageDialogModule(reactContext, mActivityEventListener),
new FBProfileModule(),
new FBProfileModule(reactContext),
new FBSettingsModule(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't FBSettingsModule going to have the same issue 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question 🤔

new FBShareDialogModule(reactContext, mActivityEventListener)
);
Expand Down