-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate source entries got generated that caused incorrect call graph relationship. #174
Comments
I tested further, even in a case when I have the above structure where non-test source lives in root, test source lives in test sub folder, it reproed the same bug. |
@thebjorn Just wonder if you have time to look at this issue? It brings wrong result to our processing. Also another slightly variation of this issue: If I run the following cmd for this dir:
It generate two different entries with different import info but pointing to the same file, this also brought incorrect result to our processing:
|
Hi @happyhebaby ! I'm on Easter vacation right now so I don't have much bandwidth (physically and mentally ;-) ) I see the files have different names, You'll probably get what you want with
when standing in the src directory. I can see if there is a way to merge nodes based on path, but I'm not sure I'll get to it until next week... |
@thebjorn I got the above result when running from |
all sub-directories (cf. issue #174). I'm not sure if this is the way to do it though, it would probably be better if py2dep could be called for each subdirectory and then the resulting dep-graphs combined..? (although that will cause large parts of the source tree to be re-parsed)
* Branch to work on creating dependency for all sub-directories (cf. issue #174). I'm not sure if this is the way to do it though, it would probably be better if py2dep could be called for each subdirectory and then the resulting dep-graphs combined..? (although that will cause large parts of the source tree to be re-parsed) * Fix for #179 * update intersphinx format
Greetings again.
I have a test project that aim to unit test the tool integration, test and source files all live in one directory, a simplified version:
inheritance_copy:
init.py
animal.py
dog.py
test_dog.py
source code
When I run cmd under the root inheritance_copy:
It generated the following json:
It seems to me the above relationship has two issues: It generated two duplicate entry pairs such as
dog
andinheritance_copy.dog
; More seriously it referred the wrong entry(from a pair) in the relationship, one example:inheritance_copy.test_dog
importsdog
, which has a null path, it should imports 'inheritance_copy.dog, which has the correct source path. BTW if I move all the test files to subdir
test` then the duplicate pairs will not be generated and the call graph is correct.The text was updated successfully, but these errors were encountered: