capture the language exception #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an
Erroris caught by the projection, it needs to callRoOriginateLanguageExceptionto capture the callstack and provide a message for the exception.There is a lot more we should do to create a more complete experience, for example translating
HRESULT->Errorat the API and caching theErrorthrown so that we can resurface it in theApplication.unhandledExceptioncallback.Right now, this is a first step which will hopefully help Arc get better error information in our traces.
Defaulting to returning
E_FAILfor generic swift errors, since there are no "well-defined" exceptions in swift, i don't see an elegant way to translate an error to anHRESULT