have winrtclass also use the bridge pattern #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristanlabelle
approved these changes
Dec 23, 2024
stevenbrix
force-pushed
the
steve/winrt-class-bridge
branch
from
093ef7d to
8d167f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the WinRTClass to use the
AbiBridgepattern for converting to/from the ABI. This makes the API more similar to the way interfaces work, and is a pre-cursor to array supportthe bridge/contract pattern is required for classes/interfaces because they can not simply specify their abi convergence on the type themselves. as this would fail when trying to implement multiple interfaces or when using composable classes