Skip to content

feat: add support for php 8.3 and node 20 #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2023
Merged

feat: add support for php 8.3 and node 20 #376

merged 2 commits into from
Dec 14, 2023

Conversation

guoard
Copy link
Contributor

@guoard guoard commented Dec 13, 2023

Thank you for dedicating your time and effort into this repository and v5.

Summary

Add support for php 8.3 and node 20.

This PR fixes/implements :

  • Bug
  • Feature
  • Breaking changes

Explain the motivation for making this change. What existing problem does the pull request solve?

Closes #375.

Test plan (required)

Verified the CI/CD functionality on my fork, and it is functioning properly.

Checklist

  • I followed the guidelines in CONTRIBUTING guide
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

@dschotman dschotman mentioned this pull request Dec 14, 2023
@nguyenk
Copy link
Member

nguyenk commented Dec 14, 2023

Awsome, thank you so much @guoard Let's wait for the Checks to pass !

@nguyenk
Copy link
Member

nguyenk commented Dec 14, 2023

All checks passed! Merging.

@nguyenk nguyenk merged commit 670eb8f into thecodingmachine:v4 Dec 14, 2023
@cy-david-ciulla
Copy link

@guoard @nguyenk
Thank you both! ❤️
Now we only need it up on Dockerhub and we are good to go 😄

@nguyenk
Copy link
Member

nguyenk commented Dec 15, 2023

@cy-david-ciulla some test job failed, maybe temporary. I relaunched ... will keep you posted

@nguyenk
Copy link
Member

nguyenk commented Dec 15, 2023

All good, images have been pushed to Docker HUB : https://hub.docker.com/r/thecodingmachine/php/tags?page=1&name=8.3

@guoard guoard deleted the php8.3 branch December 30, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PHP 8.3 images
3 participants