Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node 22 support #389

Merged
merged 3 commits into from
May 31, 2024
Merged

Add Node 22 support #389

merged 3 commits into from
May 31, 2024

Conversation

todeveni
Copy link
Contributor

Summary

This PR fixes/implements :

  • Bug
  • Feature
  • Breaking changes

Add support for upcoming LTS version of Node

Test plan (required)

Added new make test-node command, which runs version checks for Node and npm on 8.3-cli-node* images. Didn't add this to any workflows.

Checklist

  • I followed the guidelines in CONTRIBUTING guide
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

@mistraloz
Copy link
Collaborator

Its look like good. Many thanks for this PR 👍

@mistraloz mistraloz self-requested a review May 31, 2024 09:42
@mistraloz mistraloz added the enhancement Work on new feature (or any question related to new feature) label May 31, 2024
@mistraloz mistraloz merged commit 9592740 into thecodingmachine:v4 May 31, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Work on new feature (or any question related to new feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants