Skip to content
This repository was archived by the owner on Apr 14, 2024. It is now read-only.

Github Actions #23

Closed
wants to merge 1 commit into from
Closed

Conversation

rodnaph
Copy link
Contributor

@rodnaph rodnaph commented Dec 28, 2020

Summary

Migrates from Travis CI to Github Actions, as this should better support an open source project.

Test plan (required)

The same test suite should run on Github Actions.

Checklist

  • Have you followed the guidelines in our CONTRIBUTING guide?
  • Have you lint your code locally prior to submission (make lint)?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally (make tests)?
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

@rodnaph
Copy link
Contributor Author

rodnaph commented Dec 28, 2020

Closing, this won't pass until Safe is removed...

@rodnaph rodnaph closed this Dec 28, 2020
@gulien
Copy link
Contributor

gulien commented Dec 29, 2020

Thanks a lot @rodnaph!

I wonder if with a simple Ubuntu action could run make tests? For instance: https://github.com/thecodingmachine/docker-images-php/blob/v4/.github/workflows/workflow.yml#L42.

Ideally the action should run make lint and make tests 😄

I'm currently working on the new version of Gotenberg, I'll try to find some time to help you 👍

@rodnaph
Copy link
Contributor Author

rodnaph commented Dec 29, 2020

@gulien Ah, I didn't know there was any support for docker-compose in GA, I'll add that to #22

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants