Parameter is missing for class constructor for boolean properties

[ozahorulia]

Input class:

#[Input]
class SomeInput
{
    public function __construct(
        #[Field(inputType: 'Boolean!')]
        public readonly bool $x,

        #[Field(inputType: 'Boolean!')]
        public readonly bool $y,
    ) {
    }
}

Mutation:

mutation {
  updateSomething(someInput:
    {
      x: false
      y: false
    }
  )
}

Result:

"Parameter 'x' is missing for class 'SomeInput' constructor. It should be mapped as required field."

If I change type to any other (e.g. string) - it works. If I pass true instead of false as x or y argument - it also works.
Looks like problem occurs for boolean fields with false values.

[oojacoboo]

@ozahorulia yea, this is very likely. Are you using master? Also, what's your Type annotation look like? There have been some recent improvements for Input types with a new "update" option.

[ozahorulia]

The project is in production, so not master, bust last available version (5.0.2).

My Type class looks like this:

#[Type(class: SomeClass::class)]
#[SourceField(name: 'x')]
#[SourceField(name: 'y')]
class SomeClass
{
}

And the referenced SomeClass itself of course has getX(): bool and getY(): bool methods.

[oojacoboo]

That's understandable @ozahorulia. We should have a new update released soon, 6.0. You'll likely need to wait until that happens before this issue is resolved. However, in the meantime, you might test master to see if it resolves your issue, so that we can proceed towards a PR, otherwise.

As you can see in the docs, there is a new update option for Input type annotations. This denotes the Input as an "update" action, and alters the behavior of nullable fields. I suspect that false would be evaluated properly under an "update" Input type.

Since you're using a Type annotation now. What does your factory look like? Also, why are you defining the class option on the Type annotation, when it's referring to itself? And, why are you using SourceField annotations? Your example isn't very clear to me what's going on here.

[ozahorulia]

As for Type annotation - I have no problems with that, it works just as expected. It's separated from the referenced class just in order to separate models, so it doesn't change anything in case of this issue.

I just tried #[Input(update: true)] option, as it exists in 5.0.2. Unfortunately it does not change anything for me. But it's very clear that the problem appears only if properties are promoted in the constructor.

If I declare it like this, everything works perfectly:

#[Input]
class SomeInput
{
    #[Field(inputType: 'Boolean!')]
    public bool $x;

    #[Field(inputType: 'Boolean!')]
    public bool $y;
}

Also, it has nothing to do with php8-style constructors, because this doesn't work either:

#[Field(inputType: 'Boolean!')]
public readonly bool $x,

#[Field(inputType: 'Boolean!')]
public readonly bool $y,

public function __construct(
    bool $x,
    bool $y,
) {
    $this->x = $x;
    $this->y = $y;
}

[ozahorulia]

For me it looks pretty similar to #410 and looks like it may fix the problem. Is it possible to merge #411 and tag it as 5.0.3 or something?

[oojacoboo]

@ozahorulia happy to get that merged in. We need to get at least one test written for that though. Could you help us out and push a test on the author's branch?