Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix login tests and github actions workflow #139

Merged
merged 4 commits into from
Nov 17, 2024

Conversation

ch4r-ch4r
Copy link
Contributor

  1. Fixed the following tests:
  • registers a new user and logs in
  • registers a new user with password confirmation and logs in
  • User logs in when two factor disabled, the login.id session should not be created
  • User logs in without 2FA, they should not be redirected to auth/two-factor-challenge page
  • Replaced: ->assertRedirect('/'); with: ->assertRedirect(config('devdojo.auth.settings.redirect_after_auth')); This accounts for when a user has set a custom redirect_after_auth value.
  1. Add check for copying existing.env or .env.example file before listing it (in case the .env does not exist.

  2. Add Dusk and DuskApiConfig to PestPHP install step, otherwise the tests fail because they have not been installed.

  3. Update checkout version to 4 (v2 will be depecrated soon)

  4. Update php version to 8.3

Copy link
Contributor

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbyiliev bobbyiliev merged commit b5872fb into thedevdojo:main Nov 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants