This repository was archived by the owner on Feb 7, 2025. It is now read-only.
Removal of eval #60
Closed
Removal of eval #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed due to inactivity by the author |
This was referenced Nov 8, 2016
Merged
This was referenced May 15, 2018
fletch3555
pushed a commit
that referenced
this pull request
Dec 23, 2019
Bumps [serialize-javascript](https://github.com/yahoo/serialize-javascript) from 1.7.0 to 2.1.1. <details> <summary>Release notes</summary> *Sourced from [serialize-javascript's releases](https://github.com/yahoo/serialize-javascript/releases).* > ## v2.1.0 > - Add `ignoreFunction` option ([@​realdennis](https://github.com/realdennis), [#58](https://github-redirect.dependabot.com/yahoo/serialize-javascript/issues/58)) > > ## v2.0.0 > - re-landed [#54](https://github-redirect.dependabot.com/yahoo/serialize-javascript/issues/54) with bump major version (see: [#57](https://github-redirect.dependabot.com/yahoo/serialize-javascript/issues/57)) > > ## v1.9.1 > - Revert [#54](https://github-redirect.dependabot.com/yahoo/serialize-javascript/issues/54) for breaking changes (see: https://github-redirect.dependabot.com/yahoo/serialize-javascript/issues/57) > - Bump mocha from 5.2.0 to 6.2.0 ([#56](https://github-redirect.dependabot.com/yahoo/serialize-javascript/issues/56)) > > ## v1.9.0 > * support serialize undefined ([@​nqdy666](https://github.com/nqdy666), [#54](https://github-redirect.dependabot.com/yahoo/serialize-javascript/issues/54)) > * Update Node.js versions to tests > > ## v1.8.0 > - Enhanced object literals don't have arrows ([@​jowenjowen](https://github.com/jowenjowen), [#51](https://github-redirect.dependabot.com/yahoo/serialize-javascript/issues/51)) </details> <details> <summary>Commits</summary> - [`433fc9c`](yahoo/serialize-javascript@433fc9c) 2.1.1 - [`16a68ab`](yahoo/serialize-javascript@16a68ab) Merge pull request from GHSA-h9rv-jmmf-4pgx - [`3bab6de`](yahoo/serialize-javascript@3bab6de) Bump mocha from 6.2.1 to 6.2.2 ([#60](https://github-redirect.dependabot.com/yahoo/serialize-javascript/issues/60)) - [`7a6b13d`](yahoo/serialize-javascript@7a6b13d) Bump mocha from 6.2.0 to 6.2.1 ([#59](https://github-redirect.dependabot.com/yahoo/serialize-javascript/issues/59)) - [`40cf793`](yahoo/serialize-javascript@40cf793) Migrate to nyc from istanbul - [`31c98ad`](yahoo/serialize-javascript@31c98ad) 2.1.0 - [`9b47a96`](yahoo/serialize-javascript@9b47a96) Feat. New option `ignoreFunction` according to issue#32 ([#58](https://github-redirect.dependabot.com/yahoo/serialize-javascript/issues/58)) - [`c65dd4a`](yahoo/serialize-javascript@c65dd4a) 2.0.0 - [`1879481`](yahoo/serialize-javascript@1879481) Revert "Revert "support serialize undefined ([#54](https://github-redirect.dependabot.com/yahoo/serialize-javascript/issues/54))"" - [`9ee6b1c`](yahoo/serialize-javascript@9ee6b1c) 1.9.1 - Additional commits viewable in [compare view](yahoo/serialize-javascript@v1.7.0...v2.1.1) </details> <br /> [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/the-control-group/voyager/network/alerts). </details>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eval is widely considered to be bad practice for a multitude of reasons, many of which can be found on various forums and other relevant areas.
It is highly recommended that this code be changed to remove any and all instances of eval where its use is avoidable.