Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rtl support #154

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add rtl support #154

wants to merge 2 commits into from

Conversation

3adeling
Copy link

@3adeling 3adeling commented Nov 8, 2024

In this PR, I implemented RTL support without impacting LTR functionality, taking all screen breakpoints into account.

Here’s a summary of the changes:

  • Replaced pl-* and pr-* classes with ps-* and pe-*
  • Replaced ml-* and mr-* classes with ms-* and me-*
  • Substituted left-* and right-* with start-* and end-*
  • Added rtl:space-x-reverse for all TailwindCSS screens where space-x-* was used
  • Adapted all transitions for LTR and included reversed transitions for RTL
  • Added APP_LOCALE, APP_FALLBACK_LOCALE, and APP_FAKER_LOCALE to .env.example and referenced them in config/app.php
  • Set dir="ltr" in all layout files

These changes will only take effect if dir="rtl" is specified, either by hard-coding or dynamically setting it based on the app’s locale, for example: dir="{{ app()->getLocale() == 'ar' ? 'rtl' : 'ltr' }}".

@bobbyiliev bobbyiliev requested a review from tnylea November 8, 2024 10:05
@tnylea
Copy link
Contributor

tnylea commented Nov 14, 2024

Wow! Thanks for the amazing PR. Considering this is a lot of UI updates I want to test many of this manually and make sure everything still looks good. Appreciate the PR. I'll be testing this out soon.

@3adeling
Copy link
Author

@tnylea do you need any help in testing this PR? maybe you can get help from native RTL people

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants