Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object containers in the EditorContext are not properly cleaned up #173

Closed
shamilatesoglu opened this issue Aug 1, 2022 · 2 comments
Closed
Assignees
Labels

Comments

@shamilatesoglu
Copy link

The object containers m_Nodes, m_Pins, m_Links inside EditorContext are not properly cleaned after a node or link is deleted. As long as the same EditorContext is used, these containers continue to inflate. So when a node is deleted, if a same ID is used to create another node, the FindNode function returns the previous node object with the settings of the previous node. In groups, for example, this problem causes it to have the previous group's size when a new group with the same ID is created (after the first one is deleted).

@thedmd
Copy link
Owner

thedmd commented Aug 12, 2022

Delete operation indeed should remove objects from the lists. Will work on that.
Thanks for reporting.

@thedmd
Copy link
Owner

thedmd commented Aug 21, 2022

Objects are now deleted from internal vectors when removed using delete action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants