Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reverse flow #104

Closed
wants to merge 2 commits into from
Closed

Feature/reverse flow #104

wants to merge 2 commits into from

Conversation

ToppDev
Copy link

@ToppDev ToppDev commented Mar 1, 2021

Hello,

for my project I needed the ability to not only show the flow animation from left to right [ ] => [ ] but also from right to left [ ] <= [ ].

If you want, here are the changes. Feel free to use however you like.

Best regards

thedmd added a commit that referenced this pull request Mar 12, 2021
New API:

enum class FlowDirection
{
    Forward,
    Backward
};

void Flow(LinkId linkId, FlowDirection direction = FlowDirection::Forward);
@thedmd
Copy link
Owner

thedmd commented Mar 12, 2021

Hello, thanks for PR!

I did follow your idea and added an option to choose flow direction per flow:

enum class FlowDirection
{
    Forward,
    Backward
};

void Flow(LinkId linkId, FlowDirection direction = FlowDirection::Forward);

I implementation it from scratch, because this feature could be done simpler by leveraging ability to run animation backward.

Thank you!

@thedmd thedmd closed this Mar 12, 2021
@ToppDev
Copy link
Author

ToppDev commented Mar 12, 2021

Thank you too for implementing it.

Your solution is much cleaner 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants