-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Bug) Iphone 5 - Safary - Popover && Tooltip - Tooltip does not close when focus is lost #345
Comments
@thednp Watch the video |
Check latest master, I believe |
One more suggestion: please try the previous version of our polyfill. |
This is strange indeed, the last build won't work on my Android phone as well, but I have another build working with |
My bad, it's |
I solved the carousel swipe bug, but I don't know about Popover, Tooltip, please confirm with latest master? |
The problem remains, Popover and Tooltip do not close when you lose focus |
Please tell does the demo on |
@cvaize it seems we don't have any filters/checks on the handlers or any handlers targeted at mobile devices, I believe we need to use Meanwhile, since I don't have any iPhone/iMac or any Apple, I need to know what events trigger on which device, so can you please gimme a screenshot from your iPhone&Mac for the following: // update if necessary
var button = document.getElementsByTagName('BUTTON')[0];
function testHandler(e){
if (e.target === button){
button.innerHTML = e.type;
console.log(e.type)
}
}
// iphone
document.addEventListener('touchstart',testHandler,false)
// iphone/mac
button.addEventListener('mouseout',testHandler,false)
button.addEventListener('mouseleave',testHandler,false)
button.addEventListener('focusout',testHandler,false)
button.addEventListener('blur',testHandler,false) |
Okay, here's a video of the test: https://drive.google.com/file/d/1f1n-UEIDJbKN88rz9lllq7n9xw1-if8U/view?usp=sharing |
So it looks like the events barely fire, like I imagined they would. |
Bugs remained, here is confirmation: #346 #345 |
Did you test the latest master? There have been some changes since that initial commit. On the way I got those errors too. |
In the video, I demonstrated the commits. |
Alright man, will check those asap. Thanks for the feedback. |
* moved all components into a new folder `/src/components` * some optimizations as well as code improvements with `.map()` and such, will look into more soon * fixing #347 for ScrollSpy please test @iangregory * fixing #345 for Tooltip and Popover @cvaize please test * fixing #346 and #335 @cvaize special, this time I think it's pretty much as far as we can go
@cvaize how we doin? |
@cvaize I will start documenting V4 next week and I really need your feedback. |
Sorry for the delay. I'll run tests now |
I ran tests. Bug with Carousel fixed. The current bug in iphone 5 related to Popover and Tooltip remained, I think it is not critical and you can design documentation |
@cvaize I put some time into the tooltip/popover issue and I still need help in finding a solution. |
@thednp Since I have an iphone 5 I will look for a solution, leave this issue to me. This problem is important,but it is not urgent. I will look for a solution to this problem on the weekend |
But, re-opening the tooltip on the same button does not happen, I am investigating |
https://drive.google.com/file/d/1gE2wciRp-oRm-C-n-sGYjM0rUfNhXMRC/view?usp=sharing |
I will prepare a pull request for correction |
Working on Popover, I noticed a difference in the work of Popover from the original library, Popover trigger=click https://drive.google.com/open?id=1FLgiZiXb1_USsaluczdzjteulRhAlZrg |
On iphone, the focus event doesn't work as it should. I want to use the voiced solution jquery-archive/jquery-mobile#3016 (comment) |
… events on mobile devices, in particular Iphone 5 thednp#345
That's an interesting find because on my Android, Chrome works as expected as is, without your modifications. Please send me your mobile |
User Agent: Mozilla/5.0 (iPhone; CPU iPhone OS 10_3_4 like Mac OS X) AppleWebKit/603.3.8 (KHTML, like Gecko) Version/10.0 Mobile/14G61 Safari/602.1 |
Of course, it can be determined by user agent, but there is no guarantee that this will not become a problem in the future. I have a solution for user agent |
Should I use it? |
Since our problem is strictly on Apple Safari mobile, this is the line /(iPhone|iPod|iPad)/.test(navigator.userAgent) |
Wow Safari 17% market share. |
Do you have an Iphone 10 or Iphone 11 or Ipad of the latest version, please check if Focus Event doesn't work on them either? This is necessary to check whether all mobile safaris have this problem or not. |
I wouldn't have asked for your help if I had, probably never will. I wish I had more community input. |
Listen, have it work fine on your device, I believe the fix will work with other Apple Safari mobiles as well. If somebody has a problem he can simply come and raise an issue and contribute with a fix. |
Okay, I'll do a pull request |
… mobile devices, in particular Iphone 5 thednp#345
… mobile devices, in particular Iphone 5 thednp#345
… mobile devices, in particular Iphone 5 thednp#345
(Fix) Incorrect operation of Tooltip and Popover with focus events on mobile devices, in particular Iphone 5 #345
So we good to finally close this at long last? |
Yes |
Tooltip does not close when focus is lost. Compared with the original "bootstrap 4", everything works correctly in it, so in "bootstrap.native" I consider this a bug.
https://drive.google.com/file/d/1E6spqe92n79j1nXqG4TCQk7DWiKiroOd/view?usp=sharing
The text was updated successfully, but these errors were encountered: