Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorporating components into keras-contrib #4

Closed
ahundt opened this issue Dec 19, 2017 · 2 comments
Closed

incorporating components into keras-contrib #4

ahundt opened this issue Dec 19, 2017 · 2 comments

Comments

@ahundt
Copy link

ahundt commented Dec 19, 2017

Hey, I liked the clean way you implemented some of this code and since it is MIT licensed I was planning on merging a couple things in keras-contrib with attribution, but wanted to let you know!

Do you have any numbers for the kind of training results you got or idiosyncrasies I should know about?

@theduynguyen
Copy link
Owner

theduynguyen commented Dec 20, 2017 via email

@ahundt
Copy link
Author

ahundt commented Dec 20, 2017

cool, well if you wouldn't mind reviewing my version based on yours I'd appreciate it!
keras-team/keras-contrib#197

I had to make some changes to deal with numerical issues in a way that theano would support, and I went with a simpler way of flattening the data properly while maintaining channels in the results.

I think this issue itself can be closed, thanks!

@ahundt ahundt closed this as completed Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants