Check for diffBranch existence before fetch files #115
Conversation
|
Thank you @WhiteYin for taking the time to make this change. It has been a long time pending item that I have skipped for months. I'm really glad that you made this change. |
| } | ||
| catch(err) { | ||
| isdiffBranchExisted = checkForBranchExistence(baseBranch,remote); | ||
| debug('Check whether branch is existed: ', diffBranch); |
There was a problem hiding this comment.
This PR is good to go with a success log stating that the base branch is existing.
There was a problem hiding this comment.
It would make the debugging process a bit easier.
There was a problem hiding this comment.
How about now? 😊
This PR is good to go with a success log stating that the base branch is existing.
|
I apologize for the delay in the reviewing this PR. |
| } | ||
| catch(err) { | ||
| isdiffBranchExisted = checkForBranchExistence(baseBranch,remote); | ||
| debug('Check whether branch is existed: ', diffBranch); |
| @@ -107,6 +107,7 @@ if (process.stdout.isTTY) { | |||
|
|
|||
| let committedGitFiles = []; | |||
| if (isdiffBranchExisted) { | |||
| log(success('Great, we find the ' + diffBranch + ' branch.')); | |||
There was a problem hiding this comment.
Unfortunately, I have merged this PR without noticing this line. I meant to add the log in debug mode. It's my fault that I didn't communicate well. I'm sorry for the inconvenience.
If you don't mind, could you raise another PR with a log message which prints only in debug mode?
If the base branch is found, you can put a log in debug mode. (something like Base branch exists)
If not found, a warning log can be printed in normal mode. (something like below)
The base branch(branch_name) doesn't exist
Hence all the files will be considered
There was a problem hiding this comment.
Well,that's my fault.I will fix it later.
This PR introduces a check to see if the diffBranch is existed. If not, lint all tracked files instead of fetch from origin branch or baseBranch.
Closes #114