Adds verbose config option to print output even if tasks succeed #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.js
Outdated
| @@ -142,6 +148,12 @@ if (process.stdout.isTTY) { | |||
| .then(() => { | |||
| cache.setSync("linted-hash", commitHash); | |||
| debug('Cached Current Commit Hash'); | |||
| if (options.verbose) { | |||
There was a problem hiding this comment.
It would be great if this line also check the options.output array as the log can be ignored when there is no values in the array.
There was a problem hiding this comment.
This has been handled. Please verify the changes.
|
Thank you @pragatheeswarans for taking your time to create this PR. The changes looks good. Anyway, having an additional check on this comment would make this PR good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have configured a lint rule to show warnings like,
the output is suppressed because we do not show any output if all the tasks run successfully. I have introduced a verbose flag which by default will be
false. When turned on, this will store the output to an array and will be logged to the console when all the tasks are successfully completed. This helps in seeing the lint rules which are configured aswarnin the terminal.Related Issue