Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobvoi TicWatch GTH (Pro) added as tracker #512

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Mobvoi TicWatch GTH (Pro) added as tracker #512

merged 1 commit into from
Feb 11, 2024

Conversation

DigiH
Copy link
Member

@DigiH DigiH commented Feb 7, 2024

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

Co-Authored-By: John <2012161+jgbreezer@users.noreply.github.com>
@jgbreezer
Copy link
Contributor

jgbreezer commented Feb 10, 2024

Thank you for adding it in the trackers @DigiH . I lost motivation a bit and would have come back to it at some point but was working on other things. Learnt enough during it to make it a bit easier to add something else next time though, which there probably will be in due course. Am going to test this branch.

@DigiH
Copy link
Member Author

DigiH commented Feb 10, 2024

@jgbreezer

When trying out the branch with Theengs Gateway please make sure that you're also testing it with a current development branch build of Gateway, as there was an issue with discovering device_tracker without any further properties, like the TicWatch now, which was fixed in the last commit in the development branch.

@DigiH DigiH merged commit eb0ad2e into development Feb 11, 2024
14 checks passed
@DigiH DigiH deleted the ticwatch branch February 11, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants