Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static_value bool implementation #96

Merged
merged 1 commit into from
Mar 19, 2022

Conversation

DigiH
Copy link
Member

@DigiH DigiH commented Mar 19, 2022

static_value bool implementation and MUE4094RT decoder adjustment

as per discussion

#90

and testing with various variations, a static_value property value was always published as a string. This now makes static_value bool results possible, only if the static_value definition is NOT definded as a string, i.e.

      "pres":{
         "decoder":["static_value", true],
         "is_bool":1
      },

      "pres":{
         "decoder":["static_value", false],
         "is_bool":1
      },

now resulting in

"pres":true … "pres":false

Amended the MUE4094RT as well, but couldn't really create proper test cases, as I don't have realistic servicedata samples, but working as expected in the SwitchBot Curtain change

DigiH@7090b79

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

static_value bool implementation and MUE4094RT decoder adjustment
@DigiH DigiH requested a review from 1technophile March 19, 2022 16:55
Copy link
Member

@1technophile 1technophile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1technophile
Copy link
Member

Thanks

@1technophile 1technophile merged commit 0bd7845 into theengs:development Mar 19, 2022
@DigiH DigiH deleted the static-bool branch March 19, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants