Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert we didn't yield any warnings #1062

Merged
merged 9 commits into from
Nov 19, 2020
Merged

assert we didn't yield any warnings #1062

merged 9 commits into from
Nov 19, 2020

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Nov 16, 2020

No description provided.

@evgeni
Copy link
Member Author

evgeni commented Nov 16, 2020

Hm, seems not to work, doesn't break without #1061

mdellweg
mdellweg reviewed Nov 16, 2020
View reviewed changes
@evgeni
Copy link
Member Author

evgeni commented Nov 16, 2020 •
edited
Loading

Well, the new errors are mostly valid.

mdellweg
mdellweg approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like!

@evgeni
Copy link
Member Author

evgeni commented Nov 17, 2020

repository re-record is failing due to https://projects.theforeman.org/issues/31322, yay

@evgeni
Copy link
Member Author

evgeni commented Nov 18, 2020 •
edited
Loading

okay, only job_invocation left

@evgeni evgeni linked an issue Nov 18, 2020 that may be closed by this pull request
[WARNING]: The following parameters are not supported by your server when performing create on repositories: {'organization_id'}. They were ignored. #1055
Closed
@evgeni
Copy link
Member Author

evgeni commented Nov 18, 2020

great, that seems to be a bug in prepare_params 🙄

@evgeni
Copy link
Member Author

evgeni commented Nov 18, 2020

fix in Apipie/apypie#87

@evgeni
Copy link
Member Author

evgeni commented Nov 18, 2020 •
edited
Loading

and note to myself, when fixing job_invocation tapes, also clean out the Nones from the params this will be done in #1067

@evgeni
Copy link
Member Author

evgeni commented Nov 19, 2020

@mdellweg mind re-reviewing, as this got quite a few changes after your ack?

mdellweg
mdellweg approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, looks good!

@evgeni
Copy link
Member Author

evgeni commented Nov 19, 2020

Thanks, latest push just adds a changelog fragment.

@evgeni evgeni merged commit 3fe7ba7 into theforeman:develop Nov 19, 2020
@evgeni evgeni deleted the no-warnings branch November 19, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdellweg mdellweg mdellweg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@evgeni @mdellweg