Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularize Deploying Foreman on AWS guide #3469
Modularize Deploying Foreman on AWS guide #3469
Changes from all commits
c813c3d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 30 in guides/common/modules/con_deployment-scenarios.adoc
GitHub Actions / linter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be outside the scope of your PR but I don't think we should refer to these items as prerequisites. I would be inclined to turn this into a note along these lines:
You must use Red Hat Cloud subscriptions and certified images. For more information, see ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that this is Satellite-specific. -> no change for now, but would apply suggestions/patches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Ewoud recommended not including this section because some of the 'unusable' use cases will work with certain workarounds. Sections like this also create maintenance issues because they are never updated. In theory, we could put all the limitations for cloud providers in a single section.
This is just a comment, not a recommendation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is out of scope for me follow-up PR. -> no change yet.
This file was deleted.