Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update puppet_metadata dependency to ~> 4.0 & voxpupuli-acceptance ~> 3.0 #155

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

archanaserver
Copy link
Contributor

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it, I think you need to update voxpupuli-acceptance to ~> 3.0 because I'm not sure 2.x is compatible.

Could you also submit the pull requests for at least one module to see if it works?

@archanaserver archanaserver force-pushed the update-puppet-metadata branch 2 times, most recently from 5a85a3c to 1972a41 Compare June 7, 2024 08:12
@archanaserver
Copy link
Contributor Author

@ekohl if it is working now, do we need any other changes to get it in?

@ekohl
Copy link
Member

ekohl commented Jun 26, 2024

@archanaserver it looks good, please submit PRs for all the managed modules.

@archanaserver
Copy link
Contributor Author

@ekohl I've submit all the PRs for all the managed modules, tracking it here: theforeman/foreman-infra#2087 (comment)

@ekohl ekohl merged commit 4f89c16 into theforeman:master Jul 3, 2024
2 checks passed
@archanaserver archanaserver changed the title Update puppet_metadata dependency to ~> 4.0 Update puppet_metadata dependency to ~> 4.0 & voxpupuli-acceptance ~> 3.0 Jul 5, 2024
@archanaserver archanaserver deleted the update-puppet-metadata branch July 5, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants