Fixes #30507: Use enabled hook helpers for Katello and Foreman

hooks/boot/01-kafo-hook-extensions.rb

@@ -58,7 +58,7 @@ def local_foreman_db?
   end
 
   def local_candlepin_db?
-    module_enabled?('katello') && param_value('katello', 'candlepin_manage_db')
+    candlepin_enabled? && param_value('katello', 'candlepin_manage_db')
   end
 
   def local_postgresql?
@@ -69,6 +69,10 @@ def local_redis?
     (foreman_server? && !param_value('foreman', 'jobs_sidekiq_redis_url')) || pulpcore_enabled? || devel_scenario?
   end
 
+  def candlepin_enabled?
+    katello_enabled?
+  end
+
   def pulp_enabled?
     module_enabled?('foreman_proxy_plugin_pulp') && (param_value('foreman_proxy_plugin_pulp', 'pulpnode_enabled') || param_value('foreman_proxy_plugin_pulp', 'enabled'))
   end

hooks/post/99-post_install_message.rb

@@ -7,11 +7,11 @@
     new_install_message(@kafo) if new_install?
   end
 
-  if module_enabled?('katello')
+  if katello_enabled?
     certs_generate_command_message
   end
 
-  if module_enabled?('katello_devel')
+  if devel_scenario?
     dev_server_success_message(@kafo)
     dev_new_install_message(@kafo) if new_install?
   end

hooks/pre/10-reset_data.rb

@@ -5,7 +5,7 @@ def reset
   stop_services
   start_services(['postgresql']) if local_postgresql?
   empty_db_in_postgresql('foreman') if foreman_server?
-  reset_candlepin if module_enabled?('katello')
+  reset_candlepin if candlepin_enabled?
   reset_pulp if pulp_enabled?
   empty_db_in_postgresql('pulpcore') if pulpcore_enabled?
 end

katello/hooks/boot/13-hiera.rb

@@ -1,4 +1,4 @@
-if module_enabled?('foreman')
+if foreman_server?
   # TODO: automatically get the tuning sizes - standard doesn't exist and only
   # loads base. The rest maps to config/foreman.hiera/tuning/sizes/$size.yaml
   TUNING_SIZES = ['default'] + ['medium', 'large', 'extra-large', 'extra-extra-large']

katello/hooks/post/31-cdn_setting.rb

@@ -1,4 +1,4 @@
-if !app_value(:noop) && module_enabled?('katello')
+if !app_value(:noop) && katello_enabled?
   param = get_custom_config('cdn_ssl_version')
   if param
     logger.info 'cdn_ssl_version param found, migrating to a Katello setting'

katello/hooks/pre/15-check_java.rb

@@ -15,7 +15,7 @@ def error_exit(message, code)
   kafo.class.exit code
 end
 
-if module_enabled?('katello')
+if candlepin_enabled?
   java_version_string = `/usr/bin/java -version 2>&1`
   java_version = java_version_string.split("\n")[0].split('"')[1]
 

katello/hooks/pre/20-certs_update.rb

@@ -18,7 +18,7 @@ def mark_for_update(cert_name, hostname = nil)
 cert_file = param('certs', 'server_cert').value
 key_file  = param('certs', 'server_key').value
 
-if app_value('certs_update_server_ca') && !module_enabled?('katello')
+if app_value('certs_update_server_ca') && !katello_enabled?
   fail_and_exit("--certs-update-server-ca needs to be used with katello", 101)
 end
 

katello/hooks/pre_commit/13-hiera.rb

@@ -25,7 +25,7 @@
 end
 
 current_tuning = get_custom_fact(TUNING_FACT)
-if module_enabled?('foreman')
+if foreman_server?
   new_tuning = app_value(:tuning)
 else
   new_tuning = current_tuning

katello/hooks/pre_commit/14-cdn_setting.rb

@@ -1,5 +1,4 @@
-if module_enabled?('katello') &&
-   @kafo.config.answers['katello'].is_a?(Hash) &&
+if @kafo.config.answers['katello'].is_a?(Hash) &&
    @kafo.config.answers['katello'].key?('cdn_ssl_version')
   # Using @kafo.config.answers because param() goes through PuppetModule. At
   # this point the parameter doesn't exist in the module on disk so param()