Refs #28067 - defaults for dynflow sidekiq redis #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Jan 6, 2020
| @@ -1,3 +1,5 @@ | |||
| --- | |||
| # Disable additional Phusion Passenger repo on EL, preferring EPEL/Foreman's | |||
| apache::mod::passenger::manage_repo: false | |||
| redis::params::default_install: false | |||
There was a problem hiding this comment.
I think we do want the default install. We count on that in the pulpcore module
Suggested change
| redis::params::default_install: false |
| @@ -1,3 +1,5 @@ | |||
| --- | |||
| # Disable additional Phusion Passenger repo on EL, preferring EPEL/Foreman's | |||
| apache::mod::passenger::manage_repo: false | |||
| redis::params::default_install: false | |||
| redis::params::manage_repo: false | |||
There was a problem hiding this comment.
This should be set on the redis class itself
Suggested change
| redis::params::manage_repo: false | |
| redis::manage_repo: false |
theforeman-bot
added
Waiting on contributor
Needs re-review
and removed
Not yet reviewed
Waiting on contributor
labels
ezr-ondrej
force-pushed
the
redis_sidekiq_defaults
branch
from
7ad31db to
7f9692f
Compare
1 task
|
This PR and https://github.com/theforeman/foreman-installer/pull/434/files are attempting to do the same thing. However, I think based on comments #434 is more correct at this point. |
|
Closing in favor of #434 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.