Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #30078 Add default_hostgroup plugin for the Katello scenario #515

Closed
wants to merge 1 commit into from

Conversation

apatelKmd
Copy link

Based on the recommendation provided in the support communication
https://community.theforeman.org/t/default-host-group-plugin-config-file-through-the-installer/18797/2

bin/create-migration Outdated Show resolved Hide resolved
@ehelms
Copy link
Member

ehelms commented Jun 4, 2020

Could you please open a Redmine issue and attach it in the commit message?

@apatelKmd apatelKmd changed the title Add default_hostgroup plugin for the Katello scenario Fixes #30078 Add default_hostgroup plugin for the Katello scenario Jun 9, 2020
@apatelKmd
Copy link
Author

I have added the Redmine ticket number in the title https://projects.theforeman.org/issues/30078

@ehelms
Copy link
Member

ehelms commented Jun 9, 2020

@apatelKmd Almost there! Can you edit the commit message to be the same as the title? That way when it goes into the git log it will have the right info to link it back to the Redmine issue.

@apatelKmd
Copy link
Author

@ehelms Updated the commit message.

@ehelms
Copy link
Member

ehelms commented Jun 15, 2020

@wbclark added some new tests here, could you help @apatelKmd with what changes are needed with this PR and the new tests?

@ekohl
Copy link
Member

ekohl commented Jun 25, 2020

This whole change is not needed since it's already present:

foreman::plugin::default_hostgroup: false

foreman::plugin::default_hostgroup: false

Looks like this was done prior to the installer merge so somewhere before 1.21 and my instructions on Discourse were incorrect.

https://github.com/theforeman/puppet-foreman/blob/master/manifests/plugin/default_hostgroup.pp would need to be modified to manage the config file. theforeman/puppet-foreman#601 is a similar PR that could serve as inspiration.

My apologies for misleading here.

@ekohl ekohl closed this Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants