Refs #30423 - preserve old pulpcore MEDIA_ROOT on upgrades #543
Conversation
There was a problem hiding this comment.
I don't think this is right. IMHO we should get everyone on the same layout and move files around if needed. The problem is that this means every upgrading user will forever be on a different layout than fresh installs which is hard to support.
Let's first agree on the correct layout (theforeman/puppet-pulpcore#113 (review)) and then think about how to deal with upgrades.
| @@ -14,6 +14,7 @@ certs: | |||
| foreman_proxy_content: | |||
| proxy_pulp_isos_to_pulpcore: false | |||
| proxy_pulp_yum_to_pulpcore: false | |||
| pulpcore_media_root: /var/lib/pulp | |||
There was a problem hiding this comment.
This matches the default, so no need to include this.
There was a problem hiding this comment.
It's included to make it easy to tell new installs apart from upgrades.
There was a problem hiding this comment.
Is there anything stopping us from doing this within a migration @ekohl ? |
|
Yes, it's not the appropriate place. Migrations are only for the configs and run in a RPM |
How then do you propose moving the uploaded content to the new MEDIA_ROOT directory on upgrades? I think you must have something in mind other than asking users to do it manually? |
A hook in
This should really have been done before we even started to ship it in nightly. Now I just wrote something in puppet-pulpcore but forgot a TODO so others didn't see it. |
|
Closing in favor of the alternative approach. |
Requires: theforeman/puppet-pulpcore#113
Requires: theforeman/puppet-foreman_proxy_content#275