Implement rich dependencies in gem2rpm templates

For most templates this is pretty straight forward, but for
foreman_plugin.spec.erb it combines asset reequirements into the
spec.extensions block.  That was already using the more modern
runtime_requirements.virtualize methods to generate a correct rpm
dependency list. This was never noticed because we (thankfully) don't
have foreman plugins with native extensions.

gem2rpm/default.spec.erb

@@ -67,9 +67,8 @@ BuildRequires: <%= requirement 'rubygems-devel', req %>
 <% end -%>
 <% unless spec.extensions.empty? -%>
 <% for dep in runtime_dependencies.virtualize -%>
-<% for req in dep.requirement -%>
-BuildRequires: <%= requirement(dep.name, req) %>
-<% end -%>
+<% build_requires = dep.requirement.map { |req| requirement(dep.name, req) } -%>
+BuildRequires: <%= build_requires.size > 1 ? "(#{build_requires.join(' with ')})" : build_requires.first %>
 <% end -%>
 # Compiler is required for build of gem binary extension.
 # https://fedoraproject.org/wiki/Packaging:C_and_C++#BuildRequires_and_Requires

gem2rpm/foreman_plugin.spec.erb

@@ -56,27 +56,21 @@ BuildRequires: <%= requirement "ruby#{'-devel' unless spec.extensions.empty?}",
 <% for req in spec.required_rubygems_version -%>
 BuildRequires: <%= requirement 'rubygems-devel', req %>
 <% end -%>
-<% unless spec.extensions.empty? -%>
+<% if !spec.extensions.empty? || has_assets || has_webpack -%>
 <% for dep in runtime_dependencies.virtualize -%>
-<% for req in dep.requirement -%>
-BuildRequires: <%= requirement(dep.name, req) %>
-<% end -%>
+<% build_requires = dep.requirement.map { |req| requirement(dep.name, req) } -%>
+BuildRequires: <%= build_requires.size > 1 ? "(#{build_requires.join(' with ')})" : build_requires.first %>
 <% end -%>
+<% unless spec.extensions.empty? -%>
 # Compiler is required for build of gem binary extension.
 # https://fedoraproject.org/wiki/Packaging:C_and_C++#BuildRequires_and_Requires
 BuildRequires: gcc
 <% end -%>
+<% end -%>
 <% if spec.extensions.empty? -%>
 BuildArch: noarch
 <% end -%>
 Provides: foreman-plugin-%{plugin_name} = %{version}
-<% if has_assets || has_webpack -%>
-<% for d in spec.runtime_dependencies -%>
-<% for req in d.requirement -%>
-BuildRequires: rubygem(<%= d.name %>)<%= " #{req}" unless req.empty? %>
-<% end -%>
-<% end -%>
-<% end -%>
 # end specfile generated dependencies
 <% if has_package_json -%>
 

gem2rpm/hammer_plugin.spec.erb

@@ -32,9 +32,8 @@ BuildRequires: <%= requirement 'rubygems-devel', req %>
 <% end -%>
 <% unless spec.extensions.empty? -%>
 <% for dep in runtime_dependencies.virtualize -%>
-<% for req in dep.requirement -%>
-BuildRequires: <%= requirement(dep.name, req) %>
-<% end -%>
+<% build_requires = dep.requirement.map { |req| requirement(dep.name, req) } -%>
+BuildRequires: <%= build_requires.size > 1 ? "(#{build_requires.join(' with ')})" : build_requires.first %>
 <% end -%>
 # Compiler is required for build of gem binary extension.
 # https://fedoraproject.org/wiki/Packaging:C_and_C++#BuildRequires_and_Requires

gem2rpm/smart_proxy_plugin.spec.erb

@@ -41,9 +41,8 @@ BuildRequires: <%= requirement 'rubygems-devel', req %>
 <% end -%>
 <% unless spec.extensions.empty? -%>
 <% for dep in runtime_dependencies.virtualize -%>
-<% for req in dep.requirement -%>
-BuildRequires: <%= requirement(dep.name, req) %>
-<% end -%>
+<% build_requires = dep.requirement.map { |req| requirement(dep.name, req) } -%>
+BuildRequires: <%= build_requires.size > 1 ? "(#{build_requires.join(' with ')})" : build_requires.first %>
 <% end -%>
 # Compiler is required for build of gem binary extension.
 # https://fedoraproject.org/wiki/Packaging:C_and_C++#BuildRequires_and_Requires