Update foreman, foreman-proxy & katello dependencies #10024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
reviewed
Nov 24, 2023
evgeni
reviewed
Nov 24, 2023
evgeni
reviewed
Nov 24, 2023
ekohl
force-pushed
the
rpm/develop-rich-deps-pkg-updates
branch
from
63b1d84 to
c4027a2
Compare
evgeni
reviewed
Nov 24, 2023
Comment on lines
-34
to
-35
| BuildArch: noarch | ||
| Provides: foreman-plugin-%{plugin_name} = %{version} |
There was a problem hiding this comment.
If you look carefully it's moved around, to lines 59/60. I debated moving it in the template to make the diff smaller.
evgeni
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foreman and foreman-proxy use rich dependencies, but katello is gem based and gem2rpm doesn't understand that yet.