Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubygem-smart_proxy_dynflow to 0.2.1 #3025

Merged

Conversation

iNecas
Copy link
Member

@iNecas iNecas commented Sep 20, 2018

For plugin updates, please indicate which repos this should be built into:

  • Nightly
  • 1.19
  • 1.18
  • 1.17

See Foreman's plugin maintainer documentation for more information.


@iNecas iNecas force-pushed the rpm/smart_proxy_dynflow-0.2.1 branch from a484647 to 4be8203 Compare September 20, 2018 19:55
@@ -18,9 +18,11 @@ Requires: ruby(rubygems)
Requires: foreman-proxy >= 1.12.0

%if 0%{?fedora}
Requires: rubygem(smart_proxy_dynflow_core) = %{version}
Requires: rubygem(smart_proxy_dynflow_core) >= 0.2.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to urgency of this release and the fact that smart_proxy_dynflow_core build was currently failling (http://ci.theforeman.org/blue/organizations/jenkins/foreman-packaging-rpm-pr-test/detail/foreman-packaging-rpm-pr-test/1658/pipeline/), I'm releasing the requirement on the core package here, as there is nothing we need to rely on from the core package right now, that would require the strict version constraint

@jlsherrill jlsherrill merged commit ba5a8ac into theforeman:rpm/develop Sep 20, 2018
@evgeni
Copy link
Member

evgeni commented Sep 21, 2018

tagged into 1.19 and 1.18:

$ koji tag-build foreman-plugins-1.19-nonscl-rhel7 rubygem-smart_proxy_dynflow-0.2.1-1.el7                  
Created task 133966
Watching tasks (this may be safely interrupted)...
133966 tagBuild (noarch): closed

133966 tagBuild (noarch) completed successfully

$  koji tag-build foreman-plugins-1.18-nonscl-rhel7 rubygem-smart_proxy_dynflow-0.2.1-1.el7
Created task 133967
Watching tasks (this may be safely interrupted)...
133967 tagBuild (noarch): free
133967 tagBuild (noarch): free -> closed
  0 free  0 open  1 done  0 failed

133967 tagBuild (noarch) completed successfully

@evgeni
Copy link
Member

evgeni commented Sep 21, 2018

@ekohl @ehelms given this can be just tagged in, I did not do a cherrypick PR for it. but now thinking about it, I think we still should do the pick, just to make it clean in git?

@ekohl
Copy link
Member

ekohl commented Sep 27, 2018

@evgeni yes, in general I prefer git and koji to be in sync. Even if it was just tagged in instead of released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants