Do not start foreman.service or foreman.socket on package install

[ehelms]

Warning: I do not know exactly if I am doing this right to start, or how to test this without trying to get a test build from the PR process like I would get a scratch build with RPM.

[ekohl]

After the build has finished, you add your repo from https://stagingdeb.theforeman.org/ to the system. This is on top of the regular nightly builds. The README on top of it should be fairly self-explanatory, but they live in /etc/apt/sources.list. Note you need to run apt update after changing that file since (unlike yum) apt doesn't auto refresh repo metadata.

[ehelms]

I did this to stop foreman.service from being created during apt-get install foreman, however, I wondered more broadly if this should be dropped all together in favor of systemd?

[evgeni]

Well, technically, Debian still supports non-systemd systems, so if that package would go into Debian proper, that'd be a bug.

Given we don't aim for that, we could say we only support systemd systems.

[evgeni]

FWIW, dh_installinit is still responsible for also copying the foreman.service files etc, so this line can't be dropped completely yet. But at some point we will be able to. (Needs to bump some other places to make dh_systemd_* take over the copying)

[ehelms]

Working now, after apt-get install foreman-service:

root@pipeline-foreman-server-nightly-ubuntu1804:/home/vagrant# systemctl status foreman.service
● foreman.service - Foreman
   Loaded: loaded (/lib/systemd/system/foreman.service; enabled; vendor preset: enabled)
   Active: inactive (dead)
     Docs: https://theforeman.org
root@pipeline-foreman-server-nightly-ubuntu1804:/home/vagrant# systemctl status foreman.socket
● foreman.socket - Foreman HTTP Server Accept Sockets
   Loaded: loaded (/lib/systemd/system/foreman.socket; enabled; vendor preset: enabled)
   Active: inactive (dead)
   Listen: 0.0.0.0:3000 (Stream)

This puts it in alignment with RPM based installation and prevents some weirdness that can happen where if you install foreman-service but not foreman-postgresql the app would attempt to start and error out.

[ekohl]

Note you can also use systemctl status foreman.service foreman.socket and get the output from both at once.

[evgeni]

Is this PR then the right time to drop https://github.com/theforeman/foreman-packaging/blob/deb/develop/debian/buster/foreman/foreman.init (and https://github.com/theforeman/foreman-packaging/blob/deb/develop/debian/buster/foreman/foreman.default)?

would require some further cleanup like we did for dynflow:

foreman-packaging/debian/buster/foreman/foreman.preinst

Lines 15 to 18 in a1da82f

	# remove sysv-init script
	update-rc.d dynflowd remove >/dev/null
	dpkg-maintscript-helper rm_conffile /etc/init.d/dynflowd 2.0.0~ -- "$@"
	dpkg-maintscript-helper rm_conffile /etc/default/dynflowd 2.0.0~ -- "$@"

but at least it would mean we don't actually ship an init script that we don't support at all anymore

[evgeni]

packaging wise this looks correct to me

[ehelms]

Can I do the drop of initscript separately to reduce potential issues? I can do a PR for it now. I'd like to, if this change is approved, get this in so I can continue finishing up theforeman/puppet-foreman#883

[evgeni]

Oh yeah, certainly!

[evgeni]

from a debian packaging perspective, this looks correct so ACK

I assume you tested this that it actually does what you need in your setup.

[ehelms]

To the best of my ability I tested this, this at least brings this into alignment with RPM which is a win