make /run/foreman.sock match ALL files, not only regular #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a socket is not a regular file, and thus this rule did not match on (at least) EL8.
|
(untested, I am lazy) |
|
this is supposed to fix the issues I've been seeing on EL8 in theforeman/puppet-foreman#883 (comment) |
evgeni
commented
Nov 26, 2020
| @@ -30,7 +30,7 @@ | |||
| /var/log/foreman(/.*)? gen_context(system_u:object_r:foreman_log_t,s0) | |||
|
|
|||
| /var/run/foreman(/.*)? gen_context(system_u:object_r:foreman_var_run_t,s0) | |||
| /run/foreman\.sock -- gen_context(system_u:object_r:foreman_var_run_t,s0) | |||
| /run/foreman\.sock gen_context(system_u:object_r:foreman_var_run_t,s0) | |||
There was a problem hiding this comment.
this also could be -s, but then I don't know why it works on EL7…
There was a problem hiding this comment.
It does? Weird, anyway this is okay I have never seen -s in use to be honest.
lzap
approved these changes
Nov 26, 2020
| @@ -30,7 +30,7 @@ | |||
| /var/log/foreman(/.*)? gen_context(system_u:object_r:foreman_log_t,s0) | |||
|
|
|||
| /var/run/foreman(/.*)? gen_context(system_u:object_r:foreman_var_run_t,s0) | |||
| /run/foreman\.sock -- gen_context(system_u:object_r:foreman_var_run_t,s0) | |||
| /run/foreman\.sock gen_context(system_u:object_r:foreman_var_run_t,s0) | |||
There was a problem hiding this comment.
It does? Weird, anyway this is okay I have never seen -s in use to be honest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a socket is not a regular file, and thus this rule did not match on
(at least) EL8.