Revert "Fixes #35890 - enable harmony mode with Uglifier to use ES6 syntax" #9594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theforeman-bot
added
Waiting on contributor
Not yet reviewed
Legacy JS
This reverts commit d590d56.
Ron-Lavi
force-pushed
the
revert-9567-35890-enable_harmony_mode_with_uglifier
branch
from
6feb620 to
523fed5
Compare
evgeni
approved these changes
Jan 23, 2023
evgeni
deleted the
revert-9567-35890-enable_harmony_mode_with_uglifier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9567
Failed in nightly https://community.theforeman.org/t/foreman-nightly-rpm-pipeline-1763-failed/31996
and as Evgeni stated there: "ES6 support in Uglifier is not documented as production ready (and not enabled by default), and it’s recommended to use terser-ruby instead?"
we can investigate about shifting to terser-ruby instead