Fixes #36627 - Discard irrelevant inputs on template change #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
force-pushed
the
fix-rerun
branch
4 times, most recently
from
71ffb6b
to
ff20421
Compare
MariaAga
reviewed
Aug 4, 2023
webpack/JobWizard/JobWizard.js
Outdated
Comment on lines
173
to
175
| .map(({ inputName }) => inputName) | ||
| .concat( | ||
| advanced_template_inputs.map(({ inputName }) => inputName) |
There was a problem hiding this comment.
template_inputs and advanced_template_inputs dont have a key named inputName
I assume you meant to do here something like this? (name is already defined so need to use _name)
Suggested change
| .map(({ inputName }) => inputName) | |
| .concat( | |
| advanced_template_inputs.map(({ inputName }) => inputName) | |
| .map(({ name: _name }) => _name) | |
| .concat( | |
| advanced_template_inputs.map(({ name: _name }) => _name) |
There was a problem hiding this comment.
Yes, of course. I originally used something like ({ name } => name, got yelled at by the linter for shadowing an outer variable so I just renamed things without thinking, sorry about that
Previously we kept the pre-filled values from the previous template and then sent them to the backend together with the inputs for the new template. This prevented the job from being started as the backend didn't know what to do with the extra inputs.
adamruzicka
force-pushed
the
fix-rerun
branch
2 times, most recently
from
34642d4
to
ac66294
Compare
MariaAga
approved these changes
Aug 9, 2023
|
Thank you @MariaAga ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we kept the pre-filled values from the previous template and then sent them to the backend together with the inputs for the new template. This prevented the job from being started as the backend didn't know what to do with the extra inputs.